webrtc/modules/rtp_rtcp/source/rtcp_packet.h - Issue 1170723002: Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/rtp_rtcp/source/rtcp_packet.h

Issue 1170723002: Use RtcpPacket classes for SenderReport/ReceiveReport in RTCPSender (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/modules/rtp_rtcp/source/rtcp_packet.h

diff --git a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h

index ffa3e0daf2c226bc25ccaa137e388320856b3d89..d212497edde322b73fe252b1b92c0e33af8602b2 100644

--- a/webrtc/modules/rtp_rtcp/source/rtcp_packet.h

+++ b/webrtc/modules/rtp_rtcp/source/rtcp_packet.h

@@ -234,7 +234,7 @@ class SenderReport : public RtcpPacket {

void WithOctetCount(uint32_t octet_count) {

sr_.SenderOctetCount = octet_count;

}

- bool WithReportBlock(ReportBlock* block);

+ bool WithReportBlock(const ReportBlock& block);

protected:

bool Create(uint8_t* packet,

@@ -282,7 +282,7 @@ class ReceiverReport : public RtcpPacket {

void From(uint32_t ssrc) {

rr_.SenderSSRC = ssrc;

}

- bool WithReportBlock(ReportBlock* block);

+ bool WithReportBlock(const ReportBlock& block);

protected:

bool Create(uint8_t* packet,

« no previous file with comments | « no previous file | webrtc/modules/rtp_rtcp/source/rtcp_packet.cc » ('j') | no next file with comments »