Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 1169833004: Remove FileMediaEngine. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
Reviewers:
juberti1, pthatcher1
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove FileMediaEngine. This is currently only used in libjingle/examples/call which is deprecated and not currently building. BUG= R=juberti@webrtc.org, pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/eb82309d066305e5d8e94ba1f58a4cbdbcb4f9bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1168 lines) Patch
M talk/libjingle.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M talk/libjingle_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D talk/media/base/filemediaengine.h View 1 chunk +0 lines, -329 lines 0 comments Download
D talk/media/base/filemediaengine.cc View 1 chunk +0 lines, -378 lines 0 comments Download
D talk/media/base/filemediaengine_unittest.cc View 1 chunk +0 lines, -458 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
pbos-webrtc
PTAL :)
5 years, 6 months ago (2015-06-09 21:32:36 UTC) #1
pthatcher1
lgtm
5 years, 6 months ago (2015-06-09 22:57:53 UTC) #2
juberti1
lgtm
5 years, 6 months ago (2015-06-10 04:57:16 UTC) #3
pbos-webrtc
5 years, 6 months ago (2015-06-11 08:27:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb82309d066305e5d8e94ba1f58a4cbdbcb4f9bb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698