Add sent framerates to histogram stats:

Add sent framerates to histogram stats:
"WebRTC.Video.InputFramesPerSecond",
"WebRTC.Video.SentFramesPerSecond".

BUG=488243
R=pbos@webrtc.org, stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/24b4eda6f4fdfd33d2c3e82df1390bad55953f5d

[åsapersson, 2015-06-08 11:59:00]

Patchset #1 (id:1) has been deleted

[åsapersson, 2015-06-08 12:42:47]

Patchset #2 (id:40001) has been deleted

[åsapersson, 2015-06-08 12:42:56]

Patchset #2 (id:60001) has been deleted

[åsapersson, 2015-06-09 06:40:02]

Patchset #2 (id:80001) has been deleted

[åsapersson, 2015-06-09 06:40:15]

Patchset #1 (id:20001) has been deleted

[åsapersson, 2015-06-09 07:21:11]

Patchset #1 (id:100001) has been deleted

[åsapersson, 2015-06-09 07:44:59]

asapersson@webrtc.org changed reviewers:
+ pbos@webrtc.org, stefan@webrtc.org

[pbos-webrtc, 2015-06-09 12:49:01]

https://codereview.webrtc.org/1169543005/diff/120001/webrtc/modules/video_cod...
File webrtc/modules/video_coding/main/source/media_optimization.cc (right):

https://codereview.webrtc.org/1169543005/diff/120001/webrtc/modules/video_cod...
webrtc/modules/video_coding/main/source/media_optimization.cc:133:
RTC_HISTOGRAM_COUNTS_100("WebRTC.Video.SentFramesPerSecond", fps);
Can you move these histograms to SendStatisticsProxy? I'd like us to do all
histograms from there if possible.

stats_.encode_frame_rate already contains the FPS right? Is that one good
enough, or is it a different framerate since this one's taken over the entire
lifetime?

Either way I'd like to move all of these new histograms to SendStatisticsProxy
and plumb the necessary signals (total number of frames sent for instance).
WDYT?

[åsapersson, 2015-06-12 12:22:54]

On 2015/06/09 12:49:01, pbos-webrtc wrote:
>
https://codereview.webrtc.org/1169543005/diff/120001/webrtc/modules/video_cod...
> File webrtc/modules/video_coding/main/source/media_optimization.cc (right):
> 
>
https://codereview.webrtc.org/1169543005/diff/120001/webrtc/modules/video_cod...
> webrtc/modules/video_coding/main/source/media_optimization.cc:133:
> RTC_HISTOGRAM_COUNTS_100("WebRTC.Video.SentFramesPerSecond", fps);
> Can you move these histograms to SendStatisticsProxy? I'd like us to do all
> histograms from there if possible.
> 
> stats_.encode_frame_rate already contains the FPS right? Is that one good
> enough, or is it a different framerate since this one's taken over the entire
> lifetime?
> 
> Either way I'd like to move all of these new histograms to SendStatisticsProxy
> and plumb the necessary signals (total number of frames sent for instance).
> WDYT?

Removed the encode time stats from this CL.
Moved the sent framerate histogram to SendStatisticsProxy.
The "WebRTC.Video.SentFramesPerSecond" histogram is the same as the
stats_.encode_frame_rate except that this taken over the entire lifetime.

[pbos-webrtc, 2015-06-12 12:57:26]

lgtm ship it

[pbos-webrtc, 2015-06-12 13:03:47]

https://codereview.webrtc.org/1169543005/diff/190001/webrtc/video/send_statis...
File webrtc/video/send_statistics_proxy.cc (right):

https://codereview.webrtc.org/1169543005/diff/190001/webrtc/video/send_statis...
webrtc/video/send_statistics_proxy.cc:36: void
SendStatisticsProxy::UpdateHistograms() {
See if EXCLUSIVE_LOCKS_REQUIRED(crit_) means that you can run this from the
destructor without taking crit_ inside this function.

[åsapersson, 2015-06-12 13:13:42]

On 2015/06/12 13:03:47, pbos-webrtc wrote:
>
https://codereview.webrtc.org/1169543005/diff/190001/webrtc/video/send_statis...
> File webrtc/video/send_statistics_proxy.cc (right):
> 
>
https://codereview.webrtc.org/1169543005/diff/190001/webrtc/video/send_statis...
> webrtc/video/send_statistics_proxy.cc:36: void
> SendStatisticsProxy::UpdateHistograms() {
> See if EXCLUSIVE_LOCKS_REQUIRED(crit_) means that you can run this from the
> destructor without taking crit_ inside this function.

Yes that works. Updated code.

[pbos-webrtc, 2015-06-12 14:03:34]

lgtm

[stefan-webrtc, 2015-06-16 07:35:00]

lgtm

[åsapersson, 2015-06-16 08:17:16]

Committed patchset #8 (id:250001) manually as
24b4eda6f4fdfd33d2c3e82df1390bad55953f5d (presubmit successful).