Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c

Issue 1168753002: Match existing type usage better. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master
Patch Set: Attempted test fix Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
diff --git a/webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c b/webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
index 959be7d4c832f7fd98c3540e393633cd90513c89..12d2a5d9feb001d40ce0fea70e0736d9212e2f3f 100644
--- a/webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
+++ b/webrtc/modules/audio_coding/codecs/isac/main/test/simpleKenny.c
@@ -98,7 +98,7 @@ int main(int argc, char* argv[]) {
char histFileName[500];
char averageFileName[500];
unsigned int hist[600];
- unsigned int tmpSumStreamLen = 0;
+ double tmpSumStreamLen = 0;
kwiberg-webrtc 2015/06/08 13:09:38 0.0 when you assign to a double, for clarity?
Peter Kasting 2015/06/08 20:44:29 I can if you really want, though I'm not a big fan
kwiberg-webrtc 2015/06/09 00:48:12 The WebRTC audio code is littered with float liter
Peter Kasting 2015/06/10 01:09:54 Acknowledged.
unsigned int packetCntr = 0;
unsigned int lostPacketCntr = 0;
uint8_t payload[1200];
@@ -386,7 +386,7 @@ valid values are 8 and 16.\n",
if (packetCntr == 100) {
// kbps
fprintf(averageFile, "%8.3f ",
- (double)tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
+ tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
packetCntr = 0;
tmpSumStreamLen = 0;
kwiberg-webrtc 2015/06/08 13:09:38 0.0 here too? (And in any more places?)
}
@@ -506,7 +506,7 @@ valid values are 8 and 16.\n",
if (averageFile != NULL) {
if (packetCntr > 0) {
fprintf(averageFile, "%8.3f ",
- (double)tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
+ tmpSumStreamLen * 8.0 / (30.0 * packetCntr));
}
fprintf(averageFile, "\n");
fclose(averageFile);

Powered by Google App Engine
This is Rietveld 408576698