webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc - Issue 1168753002: Match existing type usage better.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

Issue 1168753002: Match existing type usage better. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc@master

Patch Set: Attempted test fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/common_audio/signal_processing/get_scaling_square.c ('k') | webrtc/modules/audio_coding/codecs/cng/webrtc_cng.c » ('j') | webrtc/modules/audio_coding/codecs/cng/webrtc_cng.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

diff --git a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

index 8135b98711552d533ab79fa90d209f76afcf6230..d16dd3b791a2b708680d4400e6beeab08d8d8cef 100644

--- a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

+++ b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng_unittest.cc

@@ -77,7 +77,7 @@ class AudioEncoderCngTest : public ::testing::Test {

ASSERT_TRUE(cng_) << "Must call CreateCng() first.";

encoded_info_ = cng_->Encode(timestamp_, audio_, num_audio_samples_10ms_,

encoded_.size(), &encoded_[0]);

- timestamp_ += num_audio_samples_10ms_;

+ timestamp_ += static_cast<uint32_t>(num_audio_samples_10ms_);

kwiberg-webrtc 2015/06/08 13:09:37 checked_cast? Otherwise, I don't really see what t

}

// Expect |num_calls| calls to the encoder, all successful. The last call