Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java

Issue 1168313003: Revert "Landing https://webrtc-codereview.appspot.com/53669004/" (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java
diff --git a/talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java b/talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java
index 6e69310e5a6dc545d5e3b3558488445a8ba42d2b..41faab17999e890a669336bec070a0fe24bdf069 100644
--- a/talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java
+++ b/talk/examples/android/src/org/appspot/apprtc/PeerConnectionClient.java
@@ -79,10 +79,6 @@ public class PeerConnectionClient {
private static final String VIDEO_CODEC_PARAM_START_BITRATE =
"x-google-start-bitrate";
private static final String AUDIO_CODEC_PARAM_BITRATE = "maxaveragebitrate";
- private static final String AUDIO_ECHO_CANCELLATION_CONSTRAINT = "googEchoCancellation";
- private static final String AUDIO_AUTO_GAIN_CONTROL_CONSTRAINT= "googAutoGainControl";
- private static final String AUDIO_HIGH_PASS_FILTER_CONSTRAINT = "googHighpassFilter";
- private static final String AUDIO_NOISE_SUPPRESSION_CONSTRAINT = "googNoiseSuppression";
private static final String MAX_VIDEO_WIDTH_CONSTRAINT = "maxWidth";
private static final String MIN_VIDEO_WIDTH_CONSTRAINT = "minWidth";
private static final String MAX_VIDEO_HEIGHT_CONSTRAINT = "maxHeight";
@@ -148,7 +144,6 @@ public class PeerConnectionClient {
public final boolean videoCodecHwAcceleration;
public final int audioStartBitrate;
public final String audioCodec;
- public final boolean noAudioProcessing;
public final boolean cpuOveruseDetection;
public PeerConnectionParameters(
@@ -156,7 +151,7 @@ public class PeerConnectionClient {
int videoWidth, int videoHeight, int videoFps, int videoStartBitrate,
String videoCodec, boolean videoCodecHwAcceleration,
int audioStartBitrate, String audioCodec,
- boolean noAudioProcessing, boolean cpuOveruseDetection) {
+ boolean cpuOveruseDetection) {
this.videoCallEnabled = videoCallEnabled;
this.loopback = loopback;
this.videoWidth = videoWidth;
@@ -167,7 +162,6 @@ public class PeerConnectionClient {
this.videoCodecHwAcceleration = videoCodecHwAcceleration;
this.audioStartBitrate = audioStartBitrate;
this.audioCodec = audioCodec;
- this.noAudioProcessing = noAudioProcessing;
this.cpuOveruseDetection = cpuOveruseDetection;
}
}
@@ -393,18 +387,7 @@ public class PeerConnectionClient {
// Create audio constraints.
audioConstraints = new MediaConstraints();
- // added for audio performance measurements
- if (peerConnectionParameters.noAudioProcessing) {
- Log.d(TAG, "Disabling audio processing");
- audioConstraints.mandatory.add(new MediaConstraints.KeyValuePair(
- AUDIO_ECHO_CANCELLATION_CONSTRAINT, "false"));
- audioConstraints.mandatory.add(new MediaConstraints.KeyValuePair(
- AUDIO_AUTO_GAIN_CONTROL_CONSTRAINT, "false"));
- audioConstraints.mandatory.add(new MediaConstraints.KeyValuePair(
- AUDIO_HIGH_PASS_FILTER_CONSTRAINT, "false"));
- audioConstraints.mandatory.add(new MediaConstraints.KeyValuePair(
- AUDIO_NOISE_SUPPRESSION_CONSTRAINT , "false"));
- }
+
// Create SDP constraints.
sdpMediaConstraints = new MediaConstraints();
sdpMediaConstraints.mandatory.add(new MediaConstraints.KeyValuePair(

Powered by Google App Engine
This is Rietveld 408576698