Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1372)

Unified Diff: talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java

Issue 1165923002: Removes automatic setting of COMM mode in WebRTC (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/audio_device/android/audio_device_template.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java
diff --git a/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java b/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java
index 90c6610a872ddd25afcaca79c9825d760e962d77..a703c3e722b08b686d5c07a329b3aba8b03d44bf 100644
--- a/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java
+++ b/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java
@@ -151,10 +151,11 @@ public class AppRTCAudioManager {
audioManager.requestAudioFocus(null, AudioManager.STREAM_VOICE_CALL,
AudioManager.AUDIOFOCUS_GAIN_TRANSIENT);
- // Start by setting RINGTONE as default audio mode. The native WebRTC
- // audio layer will switch to COMMUNICATION mode when the first streaming
- // session starts and return to RINGTONE mode when all streaming stops.
- audioManager.setMode(AudioManager.MODE_RINGTONE);
+ // Start by setting MODE_IN_COMMUNICATION as default audio mode. It is
+ // required to be in this moden when playout and/or recording starts for
AlexG 2015/06/04 16:53:36 nit: moden -> mode?
henrika_webrtc 2015/06/05 07:41:27 Done.
+ // best possible VoIP performance.
+ // TODO(henrika): we migh want to start with RINGTONE mode here instead.
+ audioManager.setMode(AudioManager.MODE_IN_COMMUNICATION);
// Always disable microphone mute during a WebRTC call.
setMicrophoneMute(false);
« no previous file with comments | « no previous file | webrtc/modules/audio_device/android/audio_device_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698