Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1165923002: Removes automatic setting of COMM mode in WebRTC (Closed)

Created:
5 years, 6 months ago by henrika_webrtc
Modified:
5 years, 6 months ago
Reviewers:
AlexG
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removes automatic setting of COMM mode in WebRTC. It is now up to the application to ensure that it is in COMM mode before any audio streaming is started. BUG=b/21571563 R=glaznev@webrtc.org Committed: https://crrev.com/fe55c38effd2984913aa4d0f53a12f46b9a56fd4 Cr-Commit-Position: refs/heads/master@{#9383}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Patch Set 3 : Removed CHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -75 lines) Patch
M talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java View 1 1 chunk +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_device_template.h View 1 2 7 chunks +11 lines, -22 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.h View 2 chunks +4 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java View 3 chunks +3 lines, -35 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
AlexG
lgtm https://codereview.webrtc.org/1165923002/diff/1/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java File talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java (right): https://codereview.webrtc.org/1165923002/diff/1/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java#newcode155 talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java:155: // required to be in this moden when ...
5 years, 6 months ago (2015-06-04 16:53:37 UTC) #2
henrika_webrtc
https://codereview.webrtc.org/1165923002/diff/1/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java File talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java (right): https://codereview.webrtc.org/1165923002/diff/1/talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java#newcode155 talk/examples/android/src/org/appspot/apprtc/AppRTCAudioManager.java:155: // required to be in this moden when playout ...
5 years, 6 months ago (2015-06-05 07:41:28 UTC) #3
henrika_webrtc
Committed patchset #3 (id:40001) manually as fe55c38effd2984913aa4d0f53a12f46b9a56fd4 (presubmit successful).
5 years, 6 months ago (2015-06-05 09:46:07 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:57 UTC) #5
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fe55c38effd2984913aa4d0f53a12f46b9a56fd4
Cr-Commit-Position: refs/heads/master@{#9383}

Powered by Google App Engine
This is Rietveld 408576698