Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1163523007: Added CQ config for WebRTC (Closed)

Created:
5 years, 6 months ago by Sergiy Byelozyorov
Modified:
5 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Added CQ config for WebRTC R=kjellander@webrtc.org BUG=chromium:470518 Committed: https://crrev.com/bdd185faabeed81006cb376c638ca28ad6666d75 Cr-Commit-Position: refs/heads/master@{#9379}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
A infra/config/OWNERS View 1 chunk +3 lines, -0 lines 0 comments Download
A infra/config/README.md View 1 chunk +1 line, -0 lines 0 comments Download
A infra/config/cq.cfg View 1 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Sergiy Byelozyorov
5 years, 6 months ago (2015-06-05 08:50:06 UTC) #1
kjellander_webrtc
https://codereview.webrtc.org/1163523007/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.webrtc.org/1163523007/diff/1/infra/config/cq.cfg#newcode13 infra/config/cq.cfg:13: url: "https://codereview.chromium.org" Please make this codereview.webrtc.org (it's a DNS ...
5 years, 6 months ago (2015-06-05 08:50:22 UTC) #2
Sergiy Byelozyorov
https://codereview.chromium.org/1163523007/diff/1/infra/config/cq.cfg File infra/config/cq.cfg (right): https://codereview.chromium.org/1163523007/diff/1/infra/config/cq.cfg#newcode13 infra/config/cq.cfg:13: url: "https://codereview.chromium.org" On 2015/06/05 08:50:22, kjellander (webrtc) wrote: > ...
5 years, 6 months ago (2015-06-05 08:50:55 UTC) #3
kjellander_webrtc
lgtm
5 years, 6 months ago (2015-06-05 08:51:20 UTC) #4
kjellander_webrtc
Committed patchset #2 (id:20001) manually as bdd185faabeed81006cb376c638ca28ad6666d75 (presubmit successful).
5 years, 6 months ago (2015-06-05 09:02:20 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:42 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bdd185faabeed81006cb376c638ca28ad6666d75
Cr-Commit-Position: refs/heads/master@{#9379}

Powered by Google App Engine
This is Rietveld 408576698