Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 1162263012: Add SocketFactoryInterface::Prepare and fix how symmetric NAT is determined (Closed)

Created:
5 years, 6 months ago by guoweis_webrtc
Modified:
5 years, 6 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SocketFactoryInterface::Prepare and fix how symmetric NAT is determined. Also remove Bind from ServerSocket interface as it's not needed anymore. BUG=4576 R=pthatcher@webrtc.org Committed: https://crrev.com/d04d3d73ebac96c265da1527328e7c96ecc5e996 Cr-Commit-Position: refs/heads/master@{#9371}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -28 lines) Patch
M webrtc/p2p/stunprober/stunprober.h View 1 7 chunks +17 lines, -4 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober.cc View 1 2 3 chunks +10 lines, -20 lines 0 comments Download
M webrtc/p2p/stunprober/stunprober_dependencies.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
guoweis_webrtc
PTAL.
5 years, 6 months ago (2015-06-04 21:10:48 UTC) #2
pthatcher1
lgtm
5 years, 6 months ago (2015-06-04 21:36:41 UTC) #3
guoweis_webrtc
Committed patchset #3 (id:40001) manually as d04d3d73ebac96c265da1527328e7c96ecc5e996 (presubmit successful).
5 years, 6 months ago (2015-06-04 22:20:13 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:21 UTC) #5
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d04d3d73ebac96c265da1527328e7c96ecc5e996
Cr-Commit-Position: refs/heads/master@{#9371}

Powered by Google App Engine
This is Rietveld 408576698