Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: webrtc/p2p/client/portallocator_unittest.cc

Issue 1160033005: Disable some PortAllocatorTest on tsan due to flakiness (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/client/portallocator_unittest.cc
diff --git a/webrtc/p2p/client/portallocator_unittest.cc b/webrtc/p2p/client/portallocator_unittest.cc
index 148623dfb3ccdea96be528e9ac64ffb9a1b954e9..b2d4eb26aa9b3f75a917f71fbc6e49fd9dd3e4c1 100644
--- a/webrtc/p2p/client/portallocator_unittest.cc
+++ b/webrtc/p2p/client/portallocator_unittest.cc
@@ -472,6 +472,10 @@ TEST_F(PortAllocatorTest, TestDisableAdapterEnumerationMultipleInterfaces) {
CheckDisableAdapterEnumeration();
}
+// Disable for TSan v2, see
+// https://code.google.com/p/webrtc/issues/detail?id=4743 for details.
+#if !defined(THREAD_SANITIZER)
+
// Test that we can get OnCandidatesAllocationDone callback when all the ports
// are disabled.
TEST_F(PortAllocatorTest, TestDisableAllPorts) {
@@ -509,6 +513,8 @@ TEST_F(PortAllocatorTest, TestGetAllPortsNoUdpSockets) {
EXPECT_TRUE(candidate_allocation_done_);
}
+#endif // if !defined(THREAD_SANITIZER)
+
// Test that we don't crash or malfunction if we can't create UDP sockets or
// listen on TCP sockets. We still give out a local TCP address, since
// apparently this is needed for the remote side to accept our connection.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698