Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Issue 1158273010: Re-land "Convert native handles to buffers before encoding." (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
Reviewers:
magjed_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-land "Convert native handles to buffers before encoding." This reverts commit a67675506c9057bd9ffd4d76aae8b743343d434d. BUG=webrtc:4081 TBR=magjed@webrtc.org Committed: https://crrev.com/eb66e800d1f5f74ab366715d2618fbede8cf3e12 Cr-Commit-Position: refs/heads/master@{#9381}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -143 lines) Patch
M talk/app/webrtc/java/jni/androidmediadecoder_jni.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M talk/app/webrtc/java/jni/native_handle_impl.h View 2 chunks +20 lines, -0 lines 0 comments Download
M talk/media/webrtc/webrtcvideoframe_unittest.cc View 3 chunks +11 lines, -8 lines 0 comments Download
M webrtc/common_video/i420_buffer_pool.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 4 chunks +5 lines, -35 lines 0 comments Download
M webrtc/common_video/interface/video_frame_buffer.h View 5 chunks +15 lines, -14 lines 0 comments Download
M webrtc/common_video/video_frame.cc View 2 chunks +8 lines, -16 lines 0 comments Download
M webrtc/common_video/video_frame_buffer.cc View 2 chunks +20 lines, -19 lines 0 comments Download
M webrtc/modules/video_coding/main/source/generic_encoder.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/generic_encoder.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/main/source/video_sender.cc View 1 chunk +9 lines, -1 line 0 comments Download
A webrtc/test/fake_texture_frame.h View 1 chunk +56 lines, -0 lines 0 comments Download
M webrtc/video/video_encoder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/video/video_encoder_unittest.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 3 chunks +10 lines, -22 lines 0 comments Download
M webrtc/video_encoder.h View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/video_engine/vie_capturer_unittest.cc View 4 chunks +10 lines, -12 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/video_frame.h View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pbos-webrtc
Committed patchset #1 (id:1) manually as eb66e800d1f5f74ab366715d2618fbede8cf3e12 (presubmit successful).
5 years, 6 months ago (2015-06-05 09:08:18 UTC) #1
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:49 UTC) #2
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb66e800d1f5f74ab366715d2618fbede8cf3e12
Cr-Commit-Position: refs/heads/master@{#9381}

Powered by Google App Engine
This is Rietveld 408576698