Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1533)

Unified Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1156143005: Report metrics about negotiated ciphers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/peerconnectioninterface.h
diff --git a/talk/app/webrtc/peerconnectioninterface.h b/talk/app/webrtc/peerconnectioninterface.h
index 3e4cb556fb5f51826734c719a5cf3f6e46bc36e8..d64775b66a6ef0c04ad2610a141b457b9aa1ef9b 100644
--- a/talk/app/webrtc/peerconnectioninterface.h
+++ b/talk/app/webrtc/peerconnectioninterface.h
@@ -127,6 +127,10 @@ class MetricsObserverInterface : public rtc::RefCountInterface {
virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0;
virtual void AddHistogramSample(PeerConnectionMetricsName type,
int value) = 0;
+ // TODO(jbauch): Make method abstract when it is implemented by Chromium.
+ virtual void CiphersNegotiated(const std::string& content_name,
juberti1 2015/06/06 00:18:40 This seems very ad-hoc. Can we abstract this into
joachim 2015/06/08 20:58:40 Are you thinking about something like IncrementCou
+ const std::string& srtp_cipher,
+ const std::string& ssl_cipher) {};
protected:
virtual ~MetricsObserverInterface() {}

Powered by Google App Engine
This is Rietveld 408576698