Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Side by Side Diff: talk/app/webrtc/peerconnectioninterface.h

Issue 1156143005: Report metrics about negotiated ciphers. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * libjingle 2 * libjingle
3 * Copyright 2012 Google Inc. 3 * Copyright 2012 Google Inc.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are met: 6 * modification, are permitted provided that the following conditions are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright notice, 8 * 1. Redistributions of source code must retain the above copyright notice,
9 * this list of conditions and the following disclaimer. 9 * this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright notice, 10 * 2. Redistributions in binary form must reproduce the above copyright notice,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 protected: 121 protected:
122 virtual ~StatsObserver() {} 122 virtual ~StatsObserver() {}
123 }; 123 };
124 124
125 class MetricsObserverInterface : public rtc::RefCountInterface { 125 class MetricsObserverInterface : public rtc::RefCountInterface {
126 public: 126 public:
127 virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0; 127 virtual void IncrementCounter(PeerConnectionMetricsCounter type) = 0;
128 virtual void AddHistogramSample(PeerConnectionMetricsName type, 128 virtual void AddHistogramSample(PeerConnectionMetricsName type,
129 int value) = 0; 129 int value) = 0;
130 // TODO(jbauch): Make method abstract when it is implemented by Chromium.
131 virtual void CiphersNegotiated(const std::string& content_name,
juberti1 2015/06/06 00:18:40 This seems very ad-hoc. Can we abstract this into
joachim 2015/06/08 20:58:40 Are you thinking about something like IncrementCou
132 const std::string& srtp_cipher,
133 const std::string& ssl_cipher) {};
130 134
131 protected: 135 protected:
132 virtual ~MetricsObserverInterface() {} 136 virtual ~MetricsObserverInterface() {}
133 }; 137 };
134 138
135 typedef MetricsObserverInterface UMAObserver; 139 typedef MetricsObserverInterface UMAObserver;
136 140
137 class PeerConnectionInterface : public rtc::RefCountInterface { 141 class PeerConnectionInterface : public rtc::RefCountInterface {
138 public: 142 public:
139 // See http://dev.w3.org/2011/webrtc/editor/webrtc.html#state-definitions . 143 // See http://dev.w3.org/2011/webrtc/editor/webrtc.html#state-definitions .
(...skipping 479 matching lines...) Expand 10 before | Expand all | Expand 10 after
619 CreatePeerConnectionFactory( 623 CreatePeerConnectionFactory(
620 rtc::Thread* worker_thread, 624 rtc::Thread* worker_thread,
621 rtc::Thread* signaling_thread, 625 rtc::Thread* signaling_thread,
622 AudioDeviceModule* default_adm, 626 AudioDeviceModule* default_adm,
623 cricket::WebRtcVideoEncoderFactory* encoder_factory, 627 cricket::WebRtcVideoEncoderFactory* encoder_factory,
624 cricket::WebRtcVideoDecoderFactory* decoder_factory); 628 cricket::WebRtcVideoDecoderFactory* decoder_factory);
625 629
626 } // namespace webrtc 630 } // namespace webrtc
627 631
628 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_ 632 #endif // TALK_APP_WEBRTC_PEERCONNECTIONINTERFACE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698