Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1152733005: Use one scoped_refptr. (Closed)

Created:
5 years, 6 months ago by pbos-webrtc
Modified:
5 years, 6 months ago
Reviewers:
tommi, kwiberg-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, andresp, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use one scoped_refptr. Uses webrtc/base/scoped_ref_ptr.h and removes the copy in system_wrappers. BUG= R=kwiberg@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/26b08605e2b99136fcc1cab0800234f469d6e236 Cr-Commit-Position: refs/heads/master@{#9370}

Patch Set 1 #

Patch Set 2 : remove from BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -227 lines) Patch
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_core_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_capture_options.h View 5 chunks +9 lines, -7 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/mouse_cursor_monitor_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/desktop_capture/screen_capturer_mac.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/shared_desktop_frame.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_mac.mm View 3 chunks +6 lines, -8 lines 0 comments Download
M webrtc/modules/desktop_capture/window_capturer_x11.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/x11/shared_x_display.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/desktop_capture/x11/shared_x_display.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/modules/rtp_rtcp/source/forward_error_correction.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_capture/ios/video_capture_ios.mm View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_capture/test/video_capture_unittest.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M webrtc/system_wrappers/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
D webrtc/system_wrappers/interface/scoped_refptr.h View 1 chunk +0 lines, -144 lines 0 comments Download
M webrtc/system_wrappers/system_wrappers.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/win/d3d_renderer.h View 2 chunks +5 lines, -5 lines 0 comments Download
M webrtc/video_engine/vie_channel.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video_engine/vie_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_engine/vie_encoder.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/video_engine/vie_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
pbos-webrtc
remove from BUILD.gn
5 years, 6 months ago (2015-06-04 09:34:17 UTC) #1
pbos-webrtc
PTAL :)
5 years, 6 months ago (2015-06-04 09:35:31 UTC) #2
tommi
Can't review right now but rs lgtm fwiw. Can you get someone else to give ...
5 years, 6 months ago (2015-06-04 10:38:31 UTC) #3
pbos-webrtc
Sure. +R kwiberg@
5 years, 6 months ago (2015-06-04 11:34:26 UTC) #5
kwiberg-webrtc
lgtm
5 years, 6 months ago (2015-06-04 12:27:36 UTC) #6
pbos-webrtc
Committed patchset #2 (id:20001) manually as 26b08605e2b99136fcc1cab0800234f469d6e236 (presubmit successful).
5 years, 6 months ago (2015-06-04 13:18:34 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26b08605e2b99136fcc1cab0800234f469d6e236
Cr-Commit-Position: refs/heads/master@{#9370}

Powered by Google App Engine
This is Rietveld 408576698