Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: talk/app/webrtc/webrtcsession_unittest.cc

Issue 1151943005: Ability to specify KeyType (RSA, ECDSA) for SSLIdentity generation in libjingle (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressing ASAN, LSAN issues in unittests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: talk/app/webrtc/webrtcsession_unittest.cc
diff --git a/talk/app/webrtc/webrtcsession_unittest.cc b/talk/app/webrtc/webrtcsession_unittest.cc
index 3a09edab911fc62149a133a24e217f69bfc54047..21f56fd2221feb478a39dfce00361eb832c0253c 100644
--- a/talk/app/webrtc/webrtcsession_unittest.cc
+++ b/talk/app/webrtc/webrtcsession_unittest.cc
@@ -31,7 +31,7 @@
#include "talk/app/webrtc/mediastreamsignaling.h"
#include "talk/app/webrtc/streamcollection.h"
#include "talk/app/webrtc/test/fakeconstraints.h"
-#include "talk/app/webrtc/test/fakedtlsidentityservice.h"
+#include "talk/app/webrtc/test/fakedtlsidentitystore.h"
#include "talk/app/webrtc/test/fakemediastreamsignaling.h"
#include "talk/app/webrtc/videotrack.h"
#include "talk/app/webrtc/webrtcsession.h"
@@ -54,6 +54,7 @@
#include "webrtc/base/network.h"
#include "webrtc/base/physicalsocketserver.h"
#include "webrtc/base/ssladapter.h"
+#include "webrtc/base/sslidentity.h"
#include "webrtc/base/sslstreamadapter.h"
#include "webrtc/base/stringutils.h"
#include "webrtc/base/thread.h"
@@ -78,8 +79,7 @@ using rtc::Thread;
using webrtc::CreateSessionDescription;
using webrtc::CreateSessionDescriptionObserver;
using webrtc::CreateSessionDescriptionRequest;
-using webrtc::DTLSIdentityRequestObserver;
-using webrtc::DTLSIdentityServiceInterface;
+using webrtc::DtlsIdentityStoreInterface;
using webrtc::FakeConstraints;
using webrtc::IceCandidateCollection;
using webrtc::JsepIceCandidate;
@@ -382,7 +382,7 @@ class WebRtcSessionTest : public testing::Test {
}
void Init(
- DTLSIdentityServiceInterface* identity_service,
+ webrtc::DtlsIdentityStoreInterface* dtls_identity_store,
const PeerConnectionInterface::RTCConfiguration& rtc_configuration) {
ASSERT_TRUE(session_.get() == NULL);
session_.reset(new WebRtcSessionForTest(
@@ -397,7 +397,8 @@ class WebRtcSessionTest : public testing::Test {
observer_.ice_gathering_state_);
EXPECT_TRUE(session_->Initialize(options_, constraints_.get(),
- identity_service, rtc_configuration));
+ rtc_configuration, dtls_identity_store,
+ rtc::KT_DEFAULT));
session_->set_metrics_observer(&metrics_observer_);
}
@@ -428,10 +429,10 @@ class WebRtcSessionTest : public testing::Test {
}
void InitWithDtls(bool identity_request_should_fail = false) {
- FakeIdentityService* identity_service = new FakeIdentityService();
- identity_service->set_should_fail(identity_request_should_fail);
+ dtls_identity_store_.reset(new FakeDtlsIdentityStoreRSA());
+ dtls_identity_store_->set_should_fail(identity_request_should_fail);
PeerConnectionInterface::RTCConfiguration configuration;
- Init(identity_service, configuration);
+ Init(dtls_identity_store_.get(), configuration);
}
void InitWithDtmfCodec() {
@@ -1281,6 +1282,7 @@ class WebRtcSessionTest : public testing::Test {
cricket::FakeVideoMediaChannel* video_channel_;
cricket::FakeVoiceMediaChannel* voice_channel_;
FakeMetricsObserver metrics_observer_;
+ rtc::scoped_ptr<FakeDtlsIdentityStoreRSA> dtls_identity_store_;
};
TEST_F(WebRtcSessionTest, TestInitializeWithDtls) {

Powered by Google App Engine
This is Rietveld 408576698