talk/app/webrtc/java/jni/peerconnection_jni.cc - Issue 1151943005: Ability to specify KeyType (RSA, ECDSA) for SSLIdentity generation in libjingle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: talk/app/webrtc/java/jni/peerconnection_jni.cc

Issue 1151943005: Ability to specify KeyType (RSA, ECDSA) for SSLIdentity generation in libjingle (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressing ASAN, LSAN issues in unittests Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« talk/app/webrtc/dtlsidentitystore.cc ('K') | « talk/app/webrtc/dtlsidentitystore_unittest.cc ('k') | talk/app/webrtc/objc/RTCPeerConnection.mm » ('j') | talk/app/webrtc/peerconnection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: talk/app/webrtc/java/jni/peerconnection_jni.cc

diff --git a/talk/app/webrtc/java/jni/peerconnection_jni.cc b/talk/app/webrtc/java/jni/peerconnection_jni.cc

index 69078e6b7e9cbaf7cbc76b512185548174825bd5..d8b1f45bfe2c6e266d680cb02fd8ed4e5ebd66a5 100644

--- a/talk/app/webrtc/java/jni/peerconnection_jni.cc

+++ b/talk/app/webrtc/java/jni/peerconnection_jni.cc

@@ -1350,7 +1350,7 @@ JOW(jlong, PeerConnectionFactory_nativeCreatePeerConnection)(

PCOJava* observer = reinterpret_cast<PCOJava*>(observer_p);

observer->SetConstraints(new ConstraintsWrapper(jni, j_constraints));

rtc::scoped_refptr<PeerConnectionInterface> pc(f->CreatePeerConnection(

- rtc_config, observer->constraints(), NULL, NULL, observer));

+ rtc_config, observer->constraints(), nullptr, observer, nullptr));

return (jlong)pc.release();

}

« talk/app/webrtc/dtlsidentitystore.cc ('K') | « talk/app/webrtc/dtlsidentitystore_unittest.cc ('k') | talk/app/webrtc/objc/RTCPeerConnection.mm » ('j') | talk/app/webrtc/peerconnection.h » ('J')