webrtc/modules/remote_bitrate_estimator/remote_rate_control.h - Issue 1151603008: Make the BWE threshold adaptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_rate_control.h

Issue 1151603008: Make the BWE threshold adaptive. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Redid the experiment settings initialization slightly and set the default threshold back to 12.5. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/remote_bitrate_estimator/remote_rate_control.h

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_rate_control.h b/webrtc/modules/remote_bitrate_estimator/remote_rate_control.h

index 4398c57fa6adb052617c59b580e060c3fa56229f..41a206af730656922b3ee79af7ba504533d0cb3e 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_rate_control.h

+++ b/webrtc/modules/remote_bitrate_estimator/remote_rate_control.h

@@ -39,8 +39,7 @@ class RemoteRateControl {

virtual uint32_t LatestEstimate() const = 0;

virtual uint32_t UpdateBandwidthEstimate(int64_t now_ms) = 0;

virtual void SetRtt(int64_t rtt) = 0;

- virtual RateControlRegion Update(const RateControlInput* input,

- int64_t now_ms) = 0;

+ virtual void Update(const RateControlInput* input, int64_t now_ms) = 0;

virtual void SetEstimate(int bitrate_bps, int64_t time_now_ms) = 0;

protected: