webrtc/modules/pacing/paced_sender.cc - Issue 1151603008: Make the BWE threshold adaptive.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/pacing/paced_sender.cc

Issue 1151603008: Make the BWE threshold adaptive. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Redid the experiment settings initialization slightly and set the default threshold back to 12.5. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/pacing/paced_sender.cc

diff --git a/webrtc/modules/pacing/paced_sender.cc b/webrtc/modules/pacing/paced_sender.cc

index f25134156b4ee12845021c110f8f7618930760c2..590ba04f44c239d8f51d196cf96af066423b21d6 100644

--- a/webrtc/modules/pacing/paced_sender.cc

+++ b/webrtc/modules/pacing/paced_sender.cc

@@ -175,6 +175,7 @@ class IntervalBudget {

void set_target_rate_kbps(int target_rate_kbps) {

target_rate_kbps_ = target_rate_kbps;

+ bytes_remaining_ = std::max(-500 * target_rate_kbps_ / 8, bytes_remaining_);

pbos-webrtc 2015/07/06 10:01:40 Named constants please.

stefan-webrtc 2015/07/06 10:54:25 Done.

}

void IncreaseBudget(int64_t delta_time_ms) {