Re-land r9378 "Rename APM Config DelayCorrection to ExtendedFilter"

talk/app/webrtc/localaudiosource.cc

Index: talk/app/webrtc/localaudiosource.cc
diff --git a/talk/app/webrtc/localaudiosource.cc b/talk/app/webrtc/localaudiosource.cc
index b37d1e3e41f8a704309465f25577adcc225ca578..65e423e968e1123f1e049ea44e507d47b9126b41 100644
--- a/talk/app/webrtc/localaudiosource.cc
+++ b/talk/app/webrtc/localaudiosource.cc
@@ -58,8 +58,14 @@ void FromConstraints(const MediaConstraintsInterface::Constraints& constraints,
     if (iter->key == MediaConstraintsInterface::kEchoCancellation)
       options->echo_cancellation.Set(value);
     else if (iter->key ==
-        MediaConstraintsInterface::kExperimentalEchoCancellation)
-      options->experimental_aec.Set(value);
+                 MediaConstraintsInterface::kExperimentalEchoCancellation ||
+             iter->key ==
+                 MediaConstraintsInterface::kExtendedFilterEchoCancellation)

[tommi, 2015/06/08 16:41:34]

hmm... don't suppose you can start adding braces :-/  as is (and before) this
goes against the style guide.
Alternatively, you could do something like this:

struct {
  const char* name;
  Settable<bool>& value;
} key_to_value[] = {
  { MediaConstraintsInterface::kEchoCancellation, options->echo_cancellation },
  // Both kExperimentalEchoCancellation (old) and
  // kExtendedFilterEchoCancellation (new) translate to extended_filter_aec
  // option being set. This is to manage the transition from the old to the
  // new without breaking dependent code.
  { MediaConstraintsInterface::kExperimentalEchoCancellation,
    options->extended_filter_aec },
  { MediaConstraintsInterface::kExtendedFilterEchoCancellation,
    options->extended_filter_aec },
  { MediaConstraintsInterface::kDAEchoCancellation,
    options->options->delay_agnostic_aec },
  ...etc
};

for (auto& entry : key_to_value) {
  if (iter->key.compare(entry.name) == 0)
    entry.value.Set(value);
}

I think it would also produce smaller code.

[hlundin-webrtc, 2015/06/09 08:42:51]

Like that?

+      // Both kExperimentalEchoCancellation (old) and
+      // kExtendedFilterEchoCancellation (new) translate to extended_filter_aec
+      // option being set. This is to manage the transition from the old to the
+      // new without breaking dependent code.
+      options->extended_filter_aec.Set(value);
     else if (iter->key == MediaConstraintsInterface::kDAEchoCancellation)
       options->delay_agnostic_aec.Set(value);
     else if (iter->key == MediaConstraintsInterface::kAutoGainControl)