Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1151173009: Disable some PortAllocatorTest on asan due to flakiness (Closed)

Created:
5 years, 6 months ago by sprang_webrtc
Modified:
5 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable some PortAllocatorTest on asan due to flakiness TBR=kjellander@webrtc.org BUG=4743 Committed: https://crrev.com/efdce6927ec37b53d9274ad604d5616d98cb58ca Cr-Commit-Position: refs/heads/master@{#9377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webrtc/p2p/client/portallocator_unittest.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sprang_webrtc
Committed patchset #1 (id:1) manually as efdce6927ec37b53d9274ad604d5616d98cb58ca (presubmit successful).
5 years, 6 months ago (2015-06-05 07:41:42 UTC) #1
kjellander_webrtc
I'm sorry but ASan is also not the same as memcheck. Please don't TBR unless ...
5 years, 6 months ago (2015-06-05 07:48:27 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:37 UTC) #3
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/efdce6927ec37b53d9274ad604d5616d98cb58ca
Cr-Commit-Position: refs/heads/master@{#9377}

Powered by Google App Engine
This is Rietveld 408576698