Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1146923006: Disable some PortAllocatorTest on valgrind memcheck due to flakiness (Closed)

Created:
5 years, 6 months ago by sprang_webrtc
Modified:
5 years, 6 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Disable some PortAllocatorTest on valgrind memcheck due to flakiness BUG=webrtc:4743 R=kjellander@webrtc.org Committed: https://crrev.com/3b2f67d90fd58eb35aa3c84632a326d34af165c6 Cr-Commit-Position: refs/heads/master@{#9382}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
sprang_webrtc
5 years, 6 months ago (2015-06-05 09:00:56 UTC) #2
kjellander_webrtc
lgtm with nit. Thanks! https://codereview.webrtc.org/1146923006/diff/1/tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt File tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt (right): https://codereview.webrtc.org/1146923006/diff/1/tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt#newcode13 tools/valgrind-webrtc/gtest_exclude/rtc_unittests.gtest-memcheck.txt:13: #Issue 4743 nit: space after ...
5 years, 6 months ago (2015-06-05 09:06:41 UTC) #3
sprang_webrtc
Committed patchset #2 (id:20001) manually as 3b2f67d90fd58eb35aa3c84632a326d34af165c6 (presubmit successful).
5 years, 6 months ago (2015-06-05 09:11:07 UTC) #4
commit-bot: I haz the power
5 years, 6 months ago (2015-06-05 12:05:51 UTC) #5
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3b2f67d90fd58eb35aa3c84632a326d34af165c6
Cr-Commit-Position: refs/heads/master@{#9382}

Powered by Google App Engine
This is Rietveld 408576698